Repository navigation
Fix inc task duration on skipped tasks - #58588
Closed
steveahnahn wants to merge 4 commits into
Closed
steveahnahn wants to merge 4 commits into
steveahnahn wants to merge 4 commits into
Conversation
potiuk
approved these changes
Dec 16, 2025
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
LGTM. But likely others who know more about the state updates should chime in.
Contributor
Author
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
Bot
added
the
stale
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Dag times out due to dagrun_timeout, unfinished task instances are marked as SKIPPED. However, their end_date remains null, causing the task duration to continuously increase in the UI as it's calculated as current_time - start_date.
Solution
Since SKIPPED is a finished state (State.finished includes SKIPPED), change includes the set_state() method so it properly sets these fields as direct assignment skips this logic.
Related Issues
Possible followup: